Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy to scan clusters with the E8 benchmark #37

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 23, 2020

This will create a policy that creates a ScanSetting binding object on
the managed cluster. This will be taken into use by the Compliance
Operator to scan the clusters for compliance with the E8 benchmark.

@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 23, 2020

Pull-request updated, HEAD is now caa0056

@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 23, 2020

Pull-request updated, HEAD is now db7a6de

@dockerymick
Copy link
Member

@JAORMX assigning myself as a reviewer to review the description in the table

@dockerymick dockerymick self-requested a review October 23, 2020 14:14
community/README.md Outdated Show resolved Hide resolved
Copy link
Member

@dockerymick dockerymick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a suggestion from a tech writer perspective. Thank you for your contributions!

This will create a policy that creates a ScanSetting binding object on
the managed cluster. This will be taken into use by the Compliance
Operator to scan the clusters for compliance with the E8 benchmark.
@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 26, 2020

Pull-request updated, HEAD is now 0c02a37

Copy link
Member

@dockerymick dockerymick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, changes look good to me

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dockerymick, JAORMX, ycao56

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ycao56 ycao56 merged commit f8ce7f3 into open-cluster-management-io:master Oct 26, 2020
dhaiducek added a commit to dhaiducek/policy-collection that referenced this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants